[ODE-591] Axiom manipulation error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.3.2
• Assignee: Alexis Midon
• Reporter: Alexis Midon
• Created: 21/Apr/09 18:55
• Updated: 29/Apr/09 21:21
• Resolved: 29/Apr/09 21:21

Description

when there's a carriage return either before or after the name then you get strange null pointer exceptions in the DeploymentWebservice code as it expects the Xml to be in a particular form and text-nodes in the DOM really make it un-happy.

This problem seems to be in the following code.

OMElement zipPart = (OMElement) namePart.getNextOMSibling();

This code is vulnerable if a carriage return is present after the <name> tag before <package> tag. AFAIK this happens because of the behaviour of Axiom. Axiom creates an OMText node for the carriage return. So when getNextOMSibling() is called instead of <package> element OMText is selected. But since the OMText cannot be cast to OMElement a ClassCastException occurs. This can be avoided by obtaining zipart OMElement with a call to getChild() or any related method which returns an OMElement reference. I can provide a patch for this if necessary.

reported by Buddhika Chamith and Ciaran.

see http://markmail.org/thread/pspxrl7qkhpraq4a

Issue Links

• is duplicated by: ODE-594 ODE DeploymentWebservice seems broken.