ODE
  1. ODE
  2. ODE-158

Unable to deal with empty "query" element in to-spec

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.1
    • Labels:
      None
    • Environment:
      JDK 1.5.0_11
      Axis2 Distro
      WinXP x64

      Description

      Note: A patch is attached for this issue.

      There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity. Ode throws an IllegalStateException stating "XPath string and xpath node are both null". It is arguable whether this is a Eclipse BPEL issue or Ode issue. I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.

      Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.

      To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.

      Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode. If the Eclipse editor fixes this on their side, this issue will go away.

      1. update.patch
        1 kB
        Richard Taylor

        Activity

        Hide
        Richard Taylor added a comment -

        A patch to fix the discussed issue. Tested in the specified environment.

        Show
        Richard Taylor added a comment - A patch to fix the discussed issue. Tested in the specified environment.
        Hide
        Matthieu Riou added a comment -

        Thanks for the nice looking code It's a reasonable fix and supporting the Eclipse BPEL editor is certainly important. Feel free to share any other "trick" for Eclipse support.

        Patch applied.

        Show
        Matthieu Riou added a comment - Thanks for the nice looking code It's a reasonable fix and supporting the Eclipse BPEL editor is certainly important. Feel free to share any other "trick" for Eclipse support. Patch applied.
        Hide
        Richard Taylor added a comment -

        Updated patch file

        Show
        Richard Taylor added a comment - Updated patch file
        Hide
        Richard Taylor added a comment -

        You're too fast! Just after submitting the patch I realized that the same
        fix applied to another method in the same file. I have updated the patch
        file, sorry about that.

        On a side note, as of a few minutes ago it appears there was a bad check in
        of DebugBpelEventListener.java. It had some extra svn tags in it and
        wouldn't compile.

        I will definitely keep an eye our for other Eclipse BPEL / Ode integration
        issues. Thanks, Rich

        Show
        Richard Taylor added a comment - You're too fast! Just after submitting the patch I realized that the same fix applied to another method in the same file. I have updated the patch file, sorry about that. On a side note, as of a few minutes ago it appears there was a bad check in of DebugBpelEventListener.java. It had some extra svn tags in it and wouldn't compile. I will definitely keep an eye our for other Eclipse BPEL / Ode integration issues. Thanks, Rich
        Hide
        Matthieu Riou added a comment -

        He he, I just happened to have my IDE open at the right place and saw your patch The second part has been applied as well.

        For the side note, I think I've corrected that today. At least it wasn't building and it now builds for me.

        Show
        Matthieu Riou added a comment - He he, I just happened to have my IDE open at the right place and saw your patch The second part has been applied as well. For the side note, I think I've corrected that today. At least it wasn't building and it now builds for me.
        Hide
        Tammo van Lessen added a comment -

        For the side note: sorry about that. I should not trust my IDE that much - at least for Java 6 it was compiling...

        As I was curious why Eclipse did not complain, I found this thing. FYI: http://blogs.sun.com/ahe/entry/override

        Show
        Tammo van Lessen added a comment - For the side note: sorry about that. I should not trust my IDE that much - at least for Java 6 it was compiling... As I was curious why Eclipse did not complain, I found this thing. FYI: http://blogs.sun.com/ahe/entry/override

          People

          • Assignee:
            Matthieu Riou
            Reporter:
            Richard Taylor
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development