[OAK-9616] Node.setPrimaryType() does not always support expanded names

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.40.0
• Fix Version/s: 1.42.0, 1.22.10, 1.8.26
• Component/s: jcr
• Assignee: Julian Reschke
• Reporter: Konrad Windszus
• Created: 05/Nov/21 14:11
• Updated: 24/Jan/22 15:38
• Resolved: 06/Nov/21 15:38

Description

Node.setPrimaryType should support both qualified and expanded name format (https://www.adobe.io/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2.7%20Equality%20of%20Names) but using qualified names sometimes lead to this exception

java.lang.IllegalArgumentException: Invalid name: {http://www.jcp.org/jcr/nt/1.0}unstructured
	at org.apache.jackrabbit.oak.spi.state.AbstractNodeState.checkValidName(AbstractNodeState.java:62)
	at org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.getChildNode(MemoryNodeBuilder.java:329)
	at org.apache.jackrabbit.oak.core.SecureNodeBuilder.<init>(SecureNodeBuilder.java:111)
	at org.apache.jackrabbit.oak.core.SecureNodeBuilder.getChildNode(SecureNodeBuilder.java:328)
	at org.apache.jackrabbit.oak.core.MutableTree.createChild(MutableTree.java:91)
	at org.apache.jackrabbit.oak.core.MutableTree.createChild(MutableTree.java:35)
	at org.apache.jackrabbit.oak.plugins.tree.impl.AbstractTree.getChild(AbstractTree.java:240)
	at org.apache.jackrabbit.oak.core.MutableTree.getChild(MutableTree.java:159)
	at org.apache.jackrabbit.oak.jcr.session.NodeImpl.internalSetPrimaryType(NodeImpl.java:1376)
	at org.apache.jackrabbit.oak.jcr.session.NodeImpl.access$700(NodeImpl.java:110)
	at org.apache.jackrabbit.oak.jcr.session.NodeImpl$25.performVoid(NodeImpl.java:965)
	at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.performVoid(SessionDelegate.java:275)
	at org.apache.jackrabbit.oak.jcr.session.NodeImpl.setPrimaryType(NodeImpl.java:954)
	at org.apache.jackrabbit.vault.packaging.integration.ImportIT.testKeepNodeTypeForFolderAggregate(ImportIT.java:407)
	...

Issue Links

• links to: GitHub Pull Request #410