[OAK-9421] AsyncIndexUpdate failure may report misleading restart time

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: core
• Assignee: Unassigned
• Reporter: Julian Reschke
• Created: 29/Apr/21 15:58
• Updated: 29/Apr/21 15:58

Description

in runWhenPermitted:

        if (isLeaseCheckEnabled(leaseTimeOut)) {
            // check for concurrent updates
            long leaseEndTime = async.getLong(leasify(name));
            long currentTime = System.currentTimeMillis();
            if (leaseEndTime > currentTime) {
                long leaseExpMsg = (leaseEndTime - currentTime) / 1000;
                String err = String.format("Another copy of the index update is already running; skipping this update. " +
                        "Time left for lease to expire %d s. Indexing can resume by %tT", leaseExpMsg, leaseEndTime);
                indexStats.failed(new Exception(err, newConcurrentUpdateException()));
                return;
            }
        }

When then lease time is set to a high value, the end time might be on the next day; so the message should include the day.