[OAK-919] Proper handling of locks present on copied nodes

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.17
• Component/s: core
• Assignee: Jukka Zitting
• Reporter: Angela Schreiber
• Created: 18/Jul/13 12:56
• Updated: 27/Feb/14 09:28
• Resolved: 11/Feb/14 12:30

Description

i just had a quick look on how copy was implemented in JR-core with respect
to locks present on the tree to be copied to a new location.

it seems that all lock related properties are skipped and thus not copied over to the new location (which IMHO makes sense though i could not find a section in the specification explicitly defining the behavior):

// copy properties
            for (Name propName : srcState.getPropertyNames()) {

[...]

/**
                 * special handling required for properties with special semantics
                 * (e.g. those defined by mix:referenceable, mix:versionable,
                 * mix:lockable, et.al.)
                 *
                 * todo FIXME delegate to 'node type instance handler'
                 */
                QPropertyDefinition def = ent.getApplicablePropertyDef(
                        srcChildState.getName(), srcChildState.getType(),
                        srcChildState.isMultiValued());
                if (NameConstants.MIX_LOCKABLE.equals(def.getDeclaringNodeType())) {
                    // skip properties defined by mix:lockable
                    continue;
                }

this is currently missing in OAK