[OAK-9094] Error message "Could not access the Lucene index" / FileNotFoundException

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.32.0
• Assignee: Mohit Kataria
• Reporter: Mohit Kataria
• Created: 27/May/20 05:54
• Updated: 07/Sep/20 10:22
• Resolved: 29/May/20 13:38

Description

It may happen that between retrieving files from remote and evaluating size of file, the remote file may get get removed leading to IO exception. Adding a check to handle this case.

IndexSanityChecker
    private boolean isThereASizeMismatch() throws IOException {
        for (String fileName : remote.listAll()){
            long localLength = DirectoryUtils.getFileLength(local, fileName);
            long remoteLength = remote.fileLength(fileName); // <== line 81

            //This is a weak check based on length.
            if (localLength > 0 && localLength != remoteLength){
                log.warn("[{}] Found local copy for {} in {} but size of local {} differs from remote {}. ",
                        indexPath, fileName, local, localLength, remoteLength);
                return true;
            }

            if (localLength > 0) {
                localDirSize += localLength;
                localFileCount++;
            }

            remoteDirSize += remoteLength;
            remoteFileCount++;
        }
        return false;
    }

OakDirectory:
   @Override
    public long fileLength(String name) throws IOException {
        NodeBuilder file = directoryBuilder.getChildNode(name);
        if (!file.exists()) {
            String msg = String.format("[%s] %s", indexName, name);
            throw new FileNotFoundException(msg);
        }
        OakIndexInput input = new OakIndexInput(name, file, indexName, blobFactory);
        try {
            return input.length();
        } finally {
            input.close();
        }
    }