Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8733

Simplify ExternalGroupPrincipalProvider

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.20.0
    • Component/s: auth-external
    • Labels:
      None

      Description

      the following 2 methods can be simplified in ExternalGroupPrincipalProvider

      • getGroupPrincipals: userTree.hasProperty(REP_EXTERNAL_PRINCIPAL_NAMES) can be omitted from the if clause, as the return value of getProperty is anyway checked for null.
      • ExternalGroupPrincipalProvider.GroupPrincipalIterator.getNext(): the PropertyValue as obtained from the ResultRow will never contain null elements and the extra check for null can be omitted. if extra defensiveness is desired the values could be filtered for null elements.

        Attachments

          Activity

            People

            • Assignee:
              angela Angela Schreiber
              Reporter:
              angela Angela Schreiber
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: