[OAK-8733] Simplify ExternalGroupPrincipalProvider

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.20.0
• Component/s: auth-external
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 31/Oct/19 17:39
• Updated: 25/Nov/19 06:28
• Resolved: 31/Oct/19 17:40

Description

the following 2 methods can be simplified in ExternalGroupPrincipalProvider

• getGroupPrincipals: userTree.hasProperty(REP_EXTERNAL_PRINCIPAL_NAMES) can be omitted from the if clause, as the return value of getProperty is anyway checked for null.
• ExternalGroupPrincipalProvider.GroupPrincipalIterator.getNext(): the PropertyValue as obtained from the ResultRow will never contain null elements and the extra check for null can be omitted. if extra defensiveness is desired the values could be filtered for null elements.