[OAK-8705] Broken logging in CopyOnWriteDirectory

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.10.5, 1.8.17
• Fix Version/s: 1.18.0, 1.8.18, 1.10.6
• Component/s: lucene
• Assignee: Thomas Mueller
• Reporter: Julian Reschke
• Created: 21/Oct/19 11:48
• Updated: 12/Nov/19 10:59
• Resolved: 30/Oct/19 13:40

Description

In trunk:

oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectory.java
437-                long remoteFileLength = remote.fileLength(name);
438-                 validLocalCopyPresent = localFileLength == remoteFileLength;
439-
440-                 if (!validLocalCopyPresent) {
441:                     log.warn("COWRemoteFileReference::file ({}) differs in length. local: {}; remote: {}, init-remote-length",
442-                             name, localFileLength, remoteFileLength);
443-                 }
444-            } else if (!IndexCopier.REMOTE_ONLY.contains(name)) {
445-                log.warn("COWRemoteFileReference::local file ({}) doesn't exist", name);

(note the trailing "init-remote-length" that does not make any sense)

Worse, in 1.10 and 1.8:

oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectory.java
426-                long remoteFileLength = remote.fileLength(name);
427-                 validLocalCopyPresent = localFileLength == remoteFileLength;
428-
429-                 if (!validLocalCopyPresent) {
430:                     log.warn("COWRemoteFileReference::file ({}) differs in length. local: {}; remote: {}, init-remote-length",
431-                             localFileLength, remoteFileLength, length);
432-                 }
433-            } else if (!IndexCopier.REMOTE_ONLY.contains(name)) {
434-                log.warn("COWRemoteFileReference::local file ({}) doesn't exist", name);

(name parameter missing, so localFileLength is logged as filename)

Proposal:

• make this consistent everywhere
• either mention "init-remote-length" and log the value, or remove it from the message
• (and fix the identation

Issue Links

• is broken by: OAK-7222 Log a warn when CoW opens input from remote due to size mismatch
• relates to: OAK-8097 Load Lucene index files before writing to the index