[OAK-8700] ExternalIdentityConflictHandler prone to NPE

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.20.0
• Component/s: auth-external
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 17/Oct/19 12:18
• Updated: 25/Nov/19 06:28
• Resolved: 30/Oct/19 16:01

Description

ExternalIdentityConflictHandler will throw NPE in case value stored in the REP_LAST_SYNCED property cannot be parsed by ISO8601.parse (and returns null) as shows the following code:

Calendar o = parse(ours.getValue(Type.DATE));
Calendar t = parse(theirs.getValue(Type.DATE));
Calendar v = o.before(t) ? t : o;
parent.setProperty(ours.getName(), v)