[OAK-869] Runtime exception while adding node

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12
• Component/s: jcr
• Assignee: Jukka Zitting
• Reporter: Antonio Sanso
• Created: 13/Jun/13 11:47
• Updated: 28/Nov/13 14:34
• Resolved: 22/Nov/13 21:04

Description

Trying to add a node where the user has not read permission ends up in a runtime exception

java.lang.IllegalStateException: This tree does not exist
at com.google.common.base.Preconditions.checkState(Preconditions.java:149)
at org.apache.jackrabbit.oak.core.TreeImpl.checkExists(TreeImpl.java:453)
at org.apache.jackrabbit.oak.core.TreeImpl.setProperty(TreeImpl.java:347)
at org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.internalAddChild(NodeDelegate.java:508)
at org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.addChild(NodeDelegate.java:462)
at org.apache.jackrabbit.oak.jcr.NodeImpl$5.perform(NodeImpl.java:256)
at org.apache.jackrabbit.oak.jcr.NodeImpl$5.perform(NodeImpl.java:1)
at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:97)
at org.apache.jackrabbit.oak.jcr.ItemImpl.perform(ItemImpl.java:95)
at org.apache.jackrabbit.oak.jcr.NodeImpl.addNode(NodeImpl.java:217)
at org.apache.jackrabbit.oak.jcr.NodeImpl.addNode(NodeImpl.java:203)
at org.apache.jackrabbit.oak.benchmark.AddChildTest.runTest(AddChildTest.java:71)
at org.apache.jackrabbit.oak.benchmark.AbstractTest.execute(AbstractTest.java:146)
at org.apache.jackrabbit.oak.benchmark.AddChildTest.execute(AddChildTest.java:1)
at org.apache.jackrabbit.oak.benchmark.AbstractTest.runTest(AbstractTest.java:115)
at org.apache.jackrabbit.oak.benchmark.AbstractTest.run(AbstractTest.java:84)
at org.apache.jackrabbit.oak.benchmark.AddChildTest.run(AddChildTest.java:1)
at org.apache.jackrabbit.oak.benchmark.BenchmarkRunner.main(BenchmarkRunner.java:114)

It would be better to have a checked excpetion instead e.g. javax.jcr.AccessDeniedException

I will attach test to reproduce the issue

Issue Links

• is blocked by: OAK-928 Read access is enforced on NEW items
• is related to: OAK-1178 MutableTree#isNew: replace implementation by NodeBuilder#isNew