[OAK-8540] Effective policies should implememt PrincipalAccessControlList

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.18.0
• Component/s: authorization-principalbased
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 14/Aug/19 06:39
• Updated: 30/Sep/19 07:34
• Resolved: 14/Aug/19 08:20

Description

currently the policies returned upon AccessControlManager.getEffectivePolicies(String) and JackrabbitAccessControlManager.getEffectivePolicies(Set<Prinicipal>) are instances of ImmutableACL, which doesn't reflect the fact that the implementation handles PrincipalAccessControlList. This makes it a bit confising to 'read' in a composite setup in particular when comparing the return value of getPolicies with getEffectivePolicies.
therefore i would suggest to introduce an extension of ImmutableACL implementing PrincipalAccessControlList and using this for the return value of both methods covering effective policies.

stillalex, fyi