[OAK-8448] VersionGC may get stuck at 60s scope

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.9
• Fix Version/s: 1.16.0, 1.10.4, 1.8.16
• Component/s: documentmk
• Assignee: Julian Reschke
• Reporter: Julian Reschke
• Created: 28/Jun/19 13:24
• Updated: 17/Aug/19 09:08
• Resolved: 09/Jul/19 12:36

Description

It seems that if the VersionGarbageCollector reduces the scope to a 60s interval, it'll never change it back to a bigger interval. This is because the collectLimit gets set to 0:

            if (scope.getDurationMs() <= options.precisionMs) {
                // If we have narrowed the collect time interval down as much as we can, no
                // longer enforce a limit. We need to get through this.
                collectLimit = 0;
                log.debug("time interval <= precision ({} ms), disabling collection limits", options.precisionMs);
            }

...and later on this is interpreted as "there were no restrictions in the prior run that need to be updated":

                if (maxCollect <= 0) {
                    log.debug("successful run without effective limit, keeping recommendations");
                }

Issue Links

• is blocked by: OAK-8453 Refactor VersionGarbageCollector to extract Recommendations class
• relates to: OAK-4780 VersionGarbageCollector should be able to run incrementally