Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8448

VersionGC may get stuck at 60s scope

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.9
    • Fix Version/s: 1.16.0, 1.10.4, 1.8.16
    • Component/s: documentmk
    • Labels:
      None

      Description

      It seems that if the VersionGarbageCollector reduces the scope to a 60s interval, it'll never change it back to a bigger interval. This is because the collectLimit gets set to 0:

                  if (scope.getDurationMs() <= options.precisionMs) {
                      // If we have narrowed the collect time interval down as much as we can, no
                      // longer enforce a limit. We need to get through this.
                      collectLimit = 0;
                      log.debug("time interval <= precision ({} ms), disabling collection limits", options.precisionMs);
                  }
      

      ...and later on this is interpreted as "there were no restrictions in the prior run that need to be updated":

                      if (maxCollect <= 0) {
                          log.debug("successful run without effective limit, keeping recommendations");
                      }
      

        Attachments

        1. OAK-8448.diff
          5 kB
          Julian Reschke
        2. test.diff
          3 kB
          Julian Reschke

          Issue Links

            Activity

              People

              • Assignee:
                reschke Julian Reschke
                Reporter:
                reschke Julian Reschke
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: