[OAK-8052] PersistentCache: failure during construction may lead to resource leak

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.6.18
• Component/s: documentmk
• Assignee: Julian Reschke
• Reporter: Julian Reschke
• Created: 15/Feb/19 11:10
• Updated: 30/Oct/19 14:25
• Resolved: 21/Feb/19 10:51

Description

In the constructor:

        readGeneration = generations.size() > 1 ? generations.first() : -1;
        writeGeneration = generations.size() > 0 ? generations.last() : 0;
        if (readGeneration >= 0) {
            readStore = createMapFactory(readGeneration, true);
        }
        writeStore = createMapFactory(writeGeneration, false);
        initBroadcast(broadcast);

...so if createMapFactory fails for writeStore, readStore will not be closed.