Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8013

[Direct Binary Access] DataRecordDownloadOptions creates invalid Content-Disposition headers - Workaround

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.12.0, 1.10.2
    • Component/s: blob-plugins
    • Labels:
      None

      Description

      DataRecordDownloadOptions always adds the extended parameter filename* to the header, without any escaping.

      Such extended parameters must not include spaces (and only a small predefined list of basic ascii chars), otherwise they have to be percent encoded. The RFC is https://tools.ietf.org/html/rfc5987 and note the definition of value-chars in the grammar.

      Because of this, if a filename includes a space or another character that must be percent encoded, this currently creates an invalid header that fails to be parsed by other clients.

      See also https://github.com/jshttp/content-disposition/issues/24

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mattvryan Matt Ryan
                Reporter:
                alexander.klimetschek Alexander Klimetschek
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: