[OAK-7880] Reduce Principal lookup in default access control code base

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.10.0, 1.9.11
• Component/s: core
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 02/Nov/18 17:13
• Updated: 05/Jun/19 15:57
• Resolved: 05/Nov/18 13:21

Description

today i spotted to places in AccessControlManagerImpl, where i think the principal lookup could be omitted altogether:

a) AccessControlManagerImpl.getPrincipal(Tree) : called when building policies from the content -> principal is always created even if not known.

b)  Util.checkValidPrincipal(Principal, PrincipalManager, int) : in case of ImportBehavior.BESTEFFORT the result of the lookup is ignored and the lookup could in this case be omitted.

stillalex, what do you think? If you feel this is worth addressing, I would create a patch.

 

Issue Links

• causes: OAK-8151 Let ACE.getPrincipal return principals obtained from PrincipalManager