Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-7880

Reduce Principal lookup in default access control code base

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.10.0, 1.9.11
    • Component/s: core
    • Labels:
      None

      Description

      today i spotted to places in AccessControlManagerImpl, where i think the principal lookup could be omitted altogether:

      a) AccessControlManagerImpl.getPrincipal(Tree) : called when building policies from the content -> principal is always created even if not known.

      b)  Util.checkValidPrincipal(Principal, PrincipalManager, int) : in case of ImportBehavior.BESTEFFORT the result of the lookup is ignored and the lookup could in this case be omitted.

      Alex Deparvu, what do you think? If you feel this is worth addressing, I would create a patch.

       

        Attachments

        1. OAK-7880.patch
          6 kB
          Angela Schreiber

          Issue Links

            Activity

              People

              • Assignee:
                angela Angela Schreiber
                Reporter:
                angela Angela Schreiber
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: