[OAK-7815] Obscure error message if AZURE_SECRET_KEY env variable is not set for Azure persistence

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.9
• Fix Version/s: 1.10.0, 1.9.10
• Component/s: segment-azure
• Assignee: Andrei Dulceanu
• Reporter: Andrei Dulceanu
• Created: 10/Oct/18 12:15
• Updated: 09/Jan/19 16:13
• Resolved: 10/Oct/18 13:29

Description

Trying to create a new Azure Segment Persistence when the AZURE_SECRET_KEY is not correctly set, fails with obscure message:

Apache Jackrabbit Oak 1.10-SNAPSHOT
Exception in thread "main" java.lang.IllegalArgumentException: The String is not a valid Base64-encoded string.
    at com.microsoft.azure.storage.core.Base64.decode(Base64.java:63)
    at com.microsoft.azure.storage.StorageCredentialsAccountAndKey.<init>(StorageCredentialsAccountAndKey.java:81)
    at org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils.createCloudBlobDirectory(ToolUtils.java:126)
    at org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils.newSegmentNodeStorePersistence(ToolUtils.java:98)
    at org.apache.jackrabbit.oak.segment.azure.tool.AzureCompact.run(AzureCompact.java:161)
    at org.apache.jackrabbit.oak.run.CompactCommand.execute(CompactCommand.java:74)
    at org.apache.jackrabbit.oak.run.Main.main(Main.java:49)

It would be nice to have here a more informative message regarding the needed environment variable.