[OAK-7724] BlobGCMbean not registered with SegmentNodeStoreFactory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0, 1.9.9
• Component/s: segment-tar
• Assignee: Amit Jain
• Reporter: Amit Jain
• Created: 31/Aug/18 08:25
• Updated: 12/Oct/18 13:30
• Resolved: 31/Aug/18 10:31

Description

SegmentNodeStoreService checks to see if the segment store is primary before registering the BlobGCMbean. 

With SegmentNodeStoreFactory the Configuration#isPrimarySegmentStore is always set to false. The intention is to not register the BlobGC when the the role is secondary in which case the condition should be changed to

ckrabbit/oak/segment/SegmentNodeStoreRegistrar.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreRegistrar.java (revision 9f1e8bdc6c91ba750ac1eea540fe59ac89ef9114)
+++ oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreRegistrar.java (date 1535703785000)
@@ -397,7 +397,7 @@
 }
 }
 
- if (cfg.isPrimarySegmentStore() && cfg.getBlobStore() instanceof GarbageCollectableBlobStore) {
+ if (!cfg.isSecondarySegmentStore() && cfg.getBlobStore() instanceof GarbageCollectableBlobStore) {
 BlobGarbageCollector gc = new MarkSweepGarbageCollector(
 new SegmentBlobReferenceRetriever(store),
 (GarbageCollectableBlobStore) cfg.getBlobStore(),