[OAK-7680] oak-commons: upgrade to project default mockito version

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.16.0, 1.10.4, 1.8.16
• Component/s: commons
• Assignee: Marcel Reutegger
• Reporter: Julian Reschke
• Created: 06/Aug/18 15:01
• Updated: 31/Jul/22 13:36
• Resolved: 03/Jul/19 10:20

Description

Unfortunately, mocking varargs seems to work different in current mockito versions. With the 2:* default from the parent pom, I'm getting the test failure below:

[ERROR] Tests run: 12, Failures: 8, Errors: 0, Skipped: 0, Time elapsed: 0.828 s <<< FAILURE! - in org.apache.jackrabbit.oak.commons.PerfLoggerTest
[ERROR] logAtDebugMessageStartWithInfoLog(org.apache.jackrabbit.oak.commons.PerfLoggerTest)  Time elapsed: 0.045 s  <<< FAILURE!
org.mockito.exceptions.verification.junit.ArgumentsAreDifferent:

Argument(s) are different! Wanted:
logger.debug(
    <any string>,
    <any java.lang.Object[]>
);
-> at org.apache.jackrabbit.oak.commons.PerfLoggerTest.verifyDebugInteractions(PerfLoggerTest.java:227)
Actual invocation has different arguments:
logger.debug(
    "message [took 0ms]",
    "argument"
);
-> at org.apache.jackrabbit.oak.commons.PerfLogger.end(PerfLogger.java:223)

        at org.apache.jackrabbit.oak.commons.PerfLoggerTest.verifyDebugInteractions(PerfLoggerTest.java:227)
        at org.apache.jackrabbit.oak.commons.PerfLoggerTest.logAtDebugMessageStartWithInfoLog(PerfLoggerTest.java:144)

Issue Links

• relates to: OAK-7367 Unify mockito versions and update to latest