Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-7473

[BlobGC] MarkSweepGarbageCollector does not always use the blobGcMaxAgeInSecs config

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.0
    • Fix Version/s: 1.10.0, 1.9.1, 1.8.18
    • Component/s: blob
    • Labels:
      None

      Description

      I wanted to use the blobGcMaxAgeInSecs config of the SegmentNodeStoreService to reduce the max age of the blobs for GC. It looks like the MarkSweepGarbageCollector[1] does no longer support the blobGcMaxAgeInSecs configuration of the SegmentNodeStoreService[3]. Instead a max age of 24h is hardcoded (added with OAK-5546 and revision r1811532 [3]) in the constructor used by the SegmentNodeStoreService.

      Looks like a regression from OAK-5546, or is there a specific reason for no longer supporting blobGcMaxAgeInSecs config?

      [1] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java#L188
      [2] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java#L690
      [3] http://svn.apache.org/viewvc?rev=1811532&view=rev

       

        Attachments

          Activity

            People

            • Assignee:
              frm Francesco Mari
              Reporter:
              pfaffm@adobe.com Marc Pfaff
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: