[OAK-7263] oak-lucene should not depend on oak-store-document

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: lucene
• Epic Link: Modularisation of Oak
• Assignee: Unassigned
• Reporter: Robert Munteanu
• Created: 13/Feb/18 14:47
• Updated: 06/Nov/19 13:40

Description

oak-lucene has a hard dependency on oak-store-document and that looks wrong to me.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project oak-lucene: Compilation failure: Compilation failure: 
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneDocumentHolder.java:[31,54] package org.apache.jackrabbit.oak.plugins.document.spi does not exist
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneDocumentHolder.java:[37,46] cannot find symbol
[ERROR]   symbol: class JournalProperty
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:[33,54] package org.apache.jackrabbit.oak.plugins.document.spi does not exist
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:[34,54] package org.apache.jackrabbit.oak.plugins.document.spi does not exist
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:[38,47] cannot find symbol
[ERROR]   symbol: class JournalPropertyBuilder
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:[106,12] cannot find symbol
[ERROR]   symbol:   class JournalProperty
[ERROR]   location: class org.apache.jackrabbit.oak.plugins.index.lucene.hybrid.LuceneJournalPropertyBuilder
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java:[55,54] package org.apache.jackrabbit.oak.plugins.document.spi does not exist
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/IndexedPaths.java:[29,54] package org.apache.jackrabbit.oak.plugins.document.spi does not exist
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/IndexedPaths.java:[33,31] cannot find symbol
[ERROR]   symbol: class JournalProperty
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyService.java:[22,54] package org.apache.jackrabbit.oak.plugins.document.spi does not exist
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyService.java:[23,54] package org.apache.jackrabbit.oak.plugins.document.spi does not exist
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyService.java:[25,54] cannot find symbol
[ERROR]   symbol: class JournalPropertyService
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyService.java:[33,12] cannot find symbol
[ERROR]   symbol:   class JournalPropertyBuilder
[ERROR]   location: class org.apache.jackrabbit.oak.plugins.index.lucene.hybrid.LuceneJournalPropertyService
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:[50,5] method does not override or implement a method from a supertype
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:[61,5] method does not override or implement a method from a supertype
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:[78,5] method does not override or implement a method from a supertype
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:[105,5] method does not override or implement a method from a supertype
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java:[618,48] cannot find symbol
[ERROR]   symbol:   class JournalPropertyService
[ERROR]   location: class org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyService.java:[32,5] method does not override or implement a method from a supertype
[ERROR] /home/robert/Documents/sources/apache/jackrabbit-oak/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyService.java:[37,5] method does not override or implement a method from a supertype

Looks like most of is it around the JournalProperty concept but I'm not familiar enough with the codebase to evaluate the dependency.

Issue Links

• relates to: OAK-6513 Journal based Async Indexer
• relates to: SLING-7446 Support Oak 1.8