[OAK-7228] Potential long overflow in MountPermissionProvider.getNumEntries

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Component/s: core, security
• Assignee: Unassigned
• Reporter: Angela Schreiber
• Created: 31/Jan/18 15:37
• Updated: 31/Jan/18 15:39
• Resolved: 31/Jan/18 15:39

Description

stillalex, just came across MountPermissionProvider.getNumEntries, which looks as follows:

@Override
        public long getNumEntries(String principalName, long max) {
            long num = 0;
            for (PermissionStoreImpl store : stores) {
                num += store.getNumEntries(principalName, max);
                if (num >= max) {
                    break;
                }
            }
            return num;
        }

If I am not mistaken this may lead to long overflow similar to the one we spotted it in PermissionEntryProviderImpl.init.

Proposed (but untested fix) could look as follows:

@Override
        public long getNumEntries(String principalName, long max) {
            long num = 0;
            for (PermissionStoreImpl store : stores) {
                num = LongUtils.safeAdd(num, store.getNumEntries(principalName, max))
                if (num >= max) {
                    break;
                }
            }
            return num;
        }

wdyt?

Issue Links

• duplicates: OAK-7227 MountPermissionProvider getNumEntries prone to overflow