[OAK-6693] Ensure that IndexNodeManager releases lock in case of error in acquiring it

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.7.8, 1.6.6, 1.8.0
• Component/s: lucene
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 21/Sep/17 08:31
• Updated: 29/Sep/17 10:09
• Resolved: 21/Sep/17 08:49

Description

Currently IndexNodeManager acquires the lock like below. Here if any exception occurs in IndexNodeImpl then lock would remain acquired

    IndexNode acquire() {
        lock.readLock().lock();
        if (closed) {
            lock.readLock().unlock();
            return null;
        } else {
            boolean success = false;
            try {
                refreshPolicy.refreshOnReadIfRequired(refreshCallback);
                success = true;
                return new IndexNodeImpl(searcherHolder);
            } finally {
                if (!success) {
                    lock.readLock().unlock();
                }
            }
        }
    }

Issue Links

• is related to: OAK-6635 IndexReader closed exception in DocumentQueue