Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-6404

Move TAR handling logic in its own package

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.3, 1.8.0
    • Component/s: segment-tar
    • Labels:
      None

      Description

      Classes related to TAR handling can be moved into a separate package. Some of those classes (FileAccess, TarReader, TarWriter, TarEntry) contain implementation details but are currently unused from the rest of the code. Access to these classes is currently encapsulated by TarFiles, which makes the refactoring almost straightforward.

      The refactoring also involves moving some monitoring interfaces (FileStoreMonitor, IOMonitor) that are supposed to be implemented externally and passed to the TAR subsystem. The TAR subsystem will use the provided implementations to communicate the progress of internal operations. Implementation of those interfaces will stay where they are.

      Finally, the refactoring involves moving TarRecovery too. This interface is implemented by the TAR subsystem and is the only reason why TarWriter is exposed to the rest of the code. This problem can be easily solved by introducing a new interface that hides the usage of a TarWriter for the recovery of a TAR entry.

        Attachments

          Activity

            People

            • Assignee:
              frm Francesco Mari
              Reporter:
              frm Francesco Mari
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: