[OAK-6147] Review SessionOperation usage in security code

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.3, 1.8.0
• Component/s: core, security
• Assignee: Alex Deparvu
• Reporter: Alex Deparvu
• Created: 02/May/17 09:49
• Updated: 08/Jan/18 13:36
• Resolved: 28/Jun/17 10:06

Description

Some of the SessionOperation usage in security related bits is entirely not correct. Most of the operations are marked as read-only, when a lot of them should be read-write.

Items to review (just did a lookup of the class, so maybe not all of them need attention):

org.apache.jackrabbit.oak.jcr.delegate.AccessControlManagerDelegator
org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator
org.apache.jackrabbit.oak.jcr.delegate.GroupDelegator
org.apache.jackrabbit.oak.jcr.delegate.ImpersonationDelegator
org.apache.jackrabbit.oak.jcr.delegate.JackrabbitAccessControlManagerDelegator
org.apache.jackrabbit.oak.jcr.delegate.PrincipalManagerDelegator
org.apache.jackrabbit.oak.jcr.delegate.PrivilegeManagerDelegator
org.apache.jackrabbit.oak.jcr.delegate.UserDelegator
org.apache.jackrabbit.oak.jcr.security.AccessManager

anchela fyi