Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-6095

Get rid of dependency from oak-segment-tar to oak-core tests

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.0, 1.8.0
    • Component/s: core, segment-tar
    • Labels:
      None

      Description

      With OAK-6073 oak-segment-tar already got rid of the regular dependency to oak-core. Looking at the test dependencies I found more room for improvement with moderate effort. The dependency to core-tests can be avoided with the following steps:

      • move all in org.apache.jackrabbit.plugins.blob.migration from oak-core to oak-blob-plugins (Note: also AbstractMigratorTest but leave DocumentToExternalMigrationTest in core).
      • move org.apache.jackrabbit.oak.fixture.NodeStoreFixture to tests in oak-store-spi (where it belongs)
      • move org.apache.jackrabbit.oak.fixture.MemoryFixture to tests in oak-store-spi (where it belongs)
      • replace dependency oak-core/tests with oak-store-spi/tests
      • add dependency to oak-store-spi type:test-jar in other modules that use the NodeStoreFixture; i.e. oak-it, oak-jcr, oak-core, oak-remote, oak-lucene.

      Michael Dürig, Francesco Mari, [~dulceanu], Alexandru Parvulescu, Marcel Reutegger, Tommaso Teofili, Robert Munteanu, does that sound reasonable to you?

        Attachments

        1. OAK-6095.patch
          7 kB
          Angela Schreiber

          Activity

            People

            • Assignee:
              angela Angela Schreiber
              Reporter:
              angela Angela Schreiber
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: