Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-6074

Simplify merge logic in LockBasedScheduler

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.3, 1.8.0
    • Component/s: segment-tar
    • Labels:
      None

      Description

      The current logic for executing a commit in LockBasedScheduler is unnecessarily intricate, containing separate strategies for optimistic and pessimistic merges. While these would have made sense in a hierarchical, multi-journal approach, when using a single journal file we always end up on the optimistic merge branch, since a commit semaphore is acquired before attempting to merge the commit. The proposal is to remove LockBasedScheduler#optimisticMerge and LockBasedScheduler#pessimisticMerge methods, simplifying the logic inside LockBasedScheduler#execute.

        Attachments

        1. OAK-6074.patch
          12 kB
          Andrei Dulceanu
        2. OAK-6074-02.patch
          16 kB
          Andrei Dulceanu

          Activity

            People

            • Assignee:
              adulceanu Andrei Dulceanu
              Reporter:
              adulceanu Andrei Dulceanu
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: