Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-6066

Migration of binaries relies on implementation details of the TarMK

    XMLWordPrintableJSON

Details

    Description

      This was uncovered with the work on OAK-6051.

      On NodeStore.merge() the TarMK uses SegmentNodeState#fastEquals to efficiently determine whether there is something to commit and whether the base state changed since the builder about to commit was acquired. For efficiency reasons fastEquals can return "false negatives". AFAIU migration of binaries depends on this implementation detail because without this optimisation migration fails. (SegmentToExternalMigrationTest and ExternalToExternalMigrationTest fail).

      Attachments

        1. OAK_6066.patch
          1 kB
          Michael Dürig

        Issue Links

          relates to

          Task - A task that needs to be done. OAK-6051 Clarify migration tests failures when switching Commit#hasChanges implementations

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              tomek.rekawek Tomek Rękawek
              mduerig Michael Dürig
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: