[OAK-5784] hashCode of RestrictionImpl doesn't include value

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0, 1.6.1, 1.8.0
• Component/s: core
• Labels: performance
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 23/Feb/17 08:44
• Updated: 06/Mar/17 13:51
• Resolved: 23/Feb/17 15:58

Description

The hashCode generation of RestrictionImpl currently looks as follows:

    public int hashCode() {
        return Objects.hashCode(definition, property);
    }

However, the hashCode of our PropertyState implementation doesn't include the value. See AbstractPropertyState:

public static int hashCode(PropertyState property) {
        return property.getName().hashCode();
    }

Consequently the hashCode of the AccessControlEntry implementation, the validation of ACEs in AccessControlValidator and the AcEntry created in the PermissionHook generates the same hashCode for entries that only differ by the value of a restriction.