[OAK-5620] Simplify consistency check

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0, 1.8.0
• Component/s: run, segment-tar
• Labels: tooling
• Assignee: Andrei Dulceanu
• Reporter: Andrei Dulceanu
• Created: 09/Feb/17 12:26
• Updated: 30/May/17 08:38
• Resolved: 13/Feb/17 15:58

Description

The current implementation of the consistency check (ConsistencyChecker,CheckCommand)
is cluttered with unnecessary checks regarding deprecated arguments of the check command.
With OAK-5595, deep traversals are enabled by default, therefore the code needs to be revised to take this into account. The same applies to the argument taken by --bin option, which was removed in OAK-5604.

Moreover, ConsistencyChecker could be refactored in order to better distinguish when:

• a full path at the given revision is checked
• a node and its properties are checked
• a node and its descendants are checked

Issue Links

• is related to: OAK-5595 The check command should do deep traversals by default
• is related to: OAK-5604 The check command should accept a non-argument "bin" option for checking binaries
• is related to: OAK-5600 Test coverage for CheckCommand