[OAK-5590] The check command doesn't do any check when "deep" option is not provided

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Fix Version/s: 1.7.0, 1.8.0
• Component/s: run, segment-tar
• Labels: tooling
• Assignee: Andrei Dulceanu
• Reporter: Andrei Dulceanu
• Created: 06/Feb/17 12:51
• Updated: 04/Oct/19 17:53
• Resolved: 08/Feb/17 10:19

Description

When the check command is used without --deep option, there is no check/traversal being done against the repository.

First relevant line in code is [1], where a check is supposed to happen, but due to a mismatch between argument expected/argument provided, null is always returned without checking anything. The method which should do the actual check [2] expects a set of paths to be traversed, but this set is always empty. Therefore, relevant code for running the check is never executed [3].

[1] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tooling/ConsistencyChecker.java#L120
[2] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tooling/ConsistencyChecker.java#L183
[3] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/tooling/ConsistencyChecker.java#L194

Issue Links

• is related to: OAK-5595 The check command should do deep traversals by default