[OAK-5355] Too eager refreshing of tree permissions in SecureNodeBuilder

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0, 1.8.0
• Component/s: core
• Labels: technical_debt
• Assignee: Angela Schreiber
• Reporter: Michael Dürig
• Created: 20/Dec/16 16:34
• Updated: 30/May/17 08:38
• Resolved: 19/May/17 08:31

Description

SecureNodeBuilder.baseChanged() calls SecureNodeBuilder.getTreePermission() even though the tree permission would be calculated lazily as needed anyway. Re-calculating the tree permissions at this point bears the risk of accessing stale data from the underlying not yet fully refreshed root (when being called e.g. from MutableRoot.refresh().

I would thus argue for removing the call to SecureNodeBuilder.getTreePermission() from SecureNodeBuilder.baseChanged().

See also OAK-5296 for an in-depth analysis.

Issue Links

• is related to: OAK-5296 MutableRoot.refresh does not correctly refresh tree permissions
• relates to: OAK-6205 SecureNodeBuild keeps unused Context field