Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-5228

Incorrect minTimestamp in DocumentNodeStore.diffImpl()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.4.8, 1.5.6
    • 1.5.15, 1.6.0, 1.4.18
    • core, documentmk
    • None

    Description

      The minTimestamp is calculated incorrectly to decide whether the journal can be used for the diff. The timestamp must be calculated from the root revisions of the node states to compare and not the revisions they were last modified. The last modified revision can potentially point very far into the past and result in a fall back to a more expensive diffManyChildren().

      Attachments

        Issue Links

          is depended upon by

          Improvement - An improvement or enhancement to an existing feature or task. OAK-6495 Fallback to classic diff when journal is broken

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. OAK-4528 diff calculation in DocumentNodeStore should try to re-use journal info on diff cache miss

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              mreutegg Marcel Reutegger
              mreutegg Marcel Reutegger
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: