Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-5133

StoreArgument class getter method opens repo in read/write and unsafe MMAP mode

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 1.5.13
    • 1.4.12, 1.5.14, 1.6.0
    • upgrade
    • None
    • Important

    Description

      It seems that the getter method hasExternalBlobReferences() for a few implementations in scope of the following commit introduced a full source repo access routine that can cause serious lock issues (especially when opened in MMAP mode for Windows environments).

      Moreover, reinitialisation of StoreArguments leads to OverlappingFileLockException.

      Such getter method should only open repository in read only mode (using buildReadOnly() of FileStoreBuilder) method.
      Considering setting MMAP always to false might be also a good idea to avoid buffer leakages (as getter should require as few features as possible) to be compatible.

      Attachments

        Issue Links

          Activity

            People

              tomek.rekawek Tomek Rękawek
              arkadius Arek Kita
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: