[OAK-5107] Avoid NullPointerException in ChangeSetFilterImpl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.13
• Fix Version/s: 1.5.14, 1.6.0
• Component/s: core
• Assignee: Stefan Egli
• Reporter: Stefan Egli
• Created: 14/Nov/16 19:40
• Updated: 06/Dec/16 10:37
• Resolved: 14/Nov/16 19:45

Description

The following exception was seen:

java.lang.NullPointerException: null
        at java.util.HashSet.<init>(HashSet.java:116)
        at org.apache.jackrabbit.oak.plugins.observation.filter.ChangeSetFilterImpl.excludes(ChangeSetFilterImpl.java:90)
        at org.apache.jackrabbit.oak.plugins.observation.filter.FilterBuilder$2.excludes(FilterBuilder.java:438)
        at org.apache.jackrabbit.oak.jcr.observation.ChangeProcessor.evalPrefilter(ChangeProcessor.java:699)
        at org.apache.jackrabbit.oak.jcr.observation.ChangeProcessor.access$900(ChangeProcessor.java:84)
        at org.apache.jackrabbit.oak.jcr.observation.ChangeProcessor$6.excludes(ChangeProcessor.java:386)
        at org.apache.jackrabbit.oak.plugins.observation.FilteringObserver.contentChanged(FilteringObserver.java:95)
        at org.apache.jackrabbit.oak.spi.commit.CompositeObserver.contentChanged(CompositeObserver.java:53)
        at org.apache.jackrabbit.oak.spi.commit.ChangeDispatcher.contentChanged(ChangeDispatcher.java:79)
        at org.apache.jackrabbit.oak.segment.SegmentNodeStore.contentChanged(SegmentNodeStore.java:655)
        at org.apache.jackrabbit.oak.segment.SegmentNodeStore.access$1000(SegmentNodeStore.java:73)
        at org.apache.jackrabbit.oak.segment.SegmentNodeStore$Commit.setHead(SegmentNodeStore.java:536)
        at org.apache.jackrabbit.oak.segment.SegmentNodeStore$Commit.optimisticMerge(SegmentNodeStore.java:581)
        at org.apache.jackrabbit.oak.segment.SegmentNodeStore$Commit.execute(SegmentNodeStore.java:635)
        at org.apache.jackrabbit.oak.segment.SegmentNodeStore.merge(SegmentNodeStore.java:289)
        at org.apache.jackrabbit.oak.spi.state.ProxyNodeStore.merge(ProxyNodeStore.java:43)
        at org.apache.jackrabbit.oak.core.MutableRoot.commit(MutableRoot.java:249)
        at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.commit(SessionDelegate.java:347)
        at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.save(SessionDelegate.java:494)
        at org.apache.jackrabbit.oak.jcr.session.SessionImpl$8.performVoid(SessionImpl.java:419)
        at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.performVoid(SessionDelegate.java:274)
        at org.apache.jackrabbit.oak.jcr.session.SessionImpl.save(SessionImpl.java:416)

Issue Links

• breaks: OAK-5151 Overflown ChangeSets are not handled correctly in ChangeSetFilterImpl
• relates to: OAK-5123 Catch any exception in ChangeSetFilterImpl.excludes - and warn.