[OAK-5094] NPE when failing to get the remote head

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.12
• Fix Version/s: 1.5.14, 1.6.0
• Component/s: segment-tar
• Flags: Patch
• Assignee: Francesco Mari
• Reporter: Timothee Maret
• Created: 10/Nov/16 16:30
• Updated: 06/Dec/16 10:37
• Resolved: 10/Nov/16 16:49

Description

org.apache.jackrabbit.oak.segment.standby.client.StandbyClient#getHead may return null in case it fails the request fails. This case is not currently handled and cause

09.11.2016 18:57:12.183 *ERROR* [sling-default-44-Registered Service.609] org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSync Failed synchronizing state
.
java.lang.NullPointerException: null
        at java.util.regex.Matcher.getTextLength(Matcher.java:1283)
        at java.util.regex.Matcher.reset(Matcher.java:309)
        at java.util.regex.Matcher.<init>(Matcher.java:229)
        at java.util.regex.Pattern.matcher(Pattern.java:1093)
        at org.apache.jackrabbit.oak.segment.RecordId.fromString(RecordId.java:48)
        at org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSyncExecution.getHead(StandbyClientSyncExecution.java:81)
        at org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSyncExecution.execute(StandbyClientSyncExecution.java:64)
        at org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSync.run(StandbyClientSync.java:141)
        at org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:118)
        at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)