[OAK-4669] Cleanup creates new generation of tar file without removing any segments

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Segment Tar 0.0.8
• Fix Version/s: Segment Tar 0.0.10
• Component/s: segment-tar
• Labels: cleanup gc
• Epic Link: SegmentMK revision GC
• Assignee: Andrei Dulceanu
• Reporter: Andrei Dulceanu
• Created: 12/Aug/16 13:05
• Updated: 04/Oct/19 17:50
• Resolved: 18/Aug/16 08:20

Description

On some deployments I have seen tar files with a quite hight generation post-fix (e.g. 'v'). From the log files I could deduce that this particular tar file was rewritten multiple times without actually any segment being removed.
I assume this is caused by the 25% gain threshold not taking the sizes contributed by the index and the graph entries into account.

The attached test case can be used to verify the above hypothesis.

Issue Links

• is related to: OAK-4667 Create IT to validate that reclaimed size after cleanup is always positive