[OAK-4652] indexName logged in QueryImpl is wrong in case of multiple indexes satisfying the query

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.5.8, 1.6.0, 1.4.25
• Component/s: query
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 05/Aug/16 11:03
• Updated: 16/Feb/21 09:55
• Resolved: 05/Aug/16 11:45

Description

QueryImpl currently computes the indexName like

 for (IndexPlan p : ipList) {
                    // TODO limit is after all conditions
                    long entryCount = Math.min(maxEntryCount, p.getEstimatedEntryCount());
                    double c = p.getCostPerExecution() + entryCount * p.getCostPerEntry();
                    if (c < cost) {
                        cost = c;
                        if (p.getPlanName() != null) {
                            indexName += "[" + p.getPlanName() + "]";
                        }
                        indexPlan = p;
                    }
                }

If there are multiple index plans then indexName contains multiple plan names which causes confusion

   cost for lucene-property[/oak:index/keymatchKeywords][/oak:index/newImport] is 786.0

Instead of concatenating the indexName should be generated outside

Issue Links

• causes: OAK-8779 QueryImpl: indexPlan used for logging always is null
• is related to: OAK-6350 Improve log reporting if multiple indexes compete for same query