Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4454

Create consistent API in ExternalSort to write and read escaped line breaks

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.18, 1.4.6, 1.5.5, 1.6.0
    • Component/s: commons
    • Labels:
      None

      Description

      ExternalSort while sorting uses EscapeUtils.unescapeLineBreaks to read lines. It is better if a new API is created with explicit expectations documented that the File being sorted has been properly escaped with EscapeUtils.escapeLineBreak.
      Otherwise, it will lead to situations like OAK-4441 where File is not escaped while writing.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                amitjain Amit Jain
                Reporter:
                amitjain Amit Jain
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: