[OAK-4443] ExternalLoginModule: refactor to handle all reasons for 'ignore' together

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: auth-external
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 08/Jun/16 11:44
• Updated: 24/Aug/16 13:03
• Resolved: 09/Jun/16 07:44

Description

while working on OAK-4417 i found ExternalLoginModule.login a bit hard to read... in particular the 3 reasons that prevent accessing the IDP are not handled together.

the proposed patch slightly refactors ExternalLoginModule. tripod, maybe you want to take a quick look? otherwise i will go ahead and commit it.