Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4421

Optimize Revison fromString and toString implementation

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5.4, 1.6.0
    • documentmk

    Description

      Current implementation of Revision fromString and toString make use of std JDK API to perform string manipulation. While running some performance test it was seen that these 2 methods are called quite frequently and that adds up to some decent times. Further they also generate quite a bit of short lived objects.

      It would be worthwhile to perform a micro benchmark of these method and optimize them further such that they perform better and also generate less garbage. The micro optimized code would be bit more complex but if performance numbers are better we can look into changing the current implementation

      Attachments

        1. revision-fromstring-caller.png
          62 kB
          Chetan Mehrotra
        2. OAK-4421-v3.patch
          8 kB
          Thomas Mueller
        3. OAK-4421-v2.patch
          6 kB
          Chetan Mehrotra
        4. OAK-4421-v1.patch
          6 kB
          Chetan Mehrotra
        5. hot-methods.png
          62 kB
          Chetan Mehrotra

        Issue Links

          Activity

            People

              chetanm Chetan Mehrotra
              chetanm Chetan Mehrotra
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: