[OAK-4307] SegmentWriter saves references to external blobs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.2, Segment Tar 0.0.2, 1.6.0
• Component/s: segment-tar
• Flags: Patch
• Assignee: Tomek Rękawek
• Reporter: Tomek Rękawek
• Created: 26/Apr/16 07:24
• Updated: 20/Jun/16 07:57
• Resolved: 26/Apr/16 09:12

Description

The new SegmentWriteOperation#internalWriteStream method checks whether the input stream to write is a SegmentStream. If it's, writer will reuse existing block ids, rather than storing the whole stream.

It should also check whether the blocks in SegmentStream comes from the same tracker / segment store. Otherwise this will create invalid references if someone invokes the internalWriteStream() method with a SegmentStream created externally.

Issue Links

• blocks: OAK-4303 Use the oak-segment-next in the oak-upgrade tests
• is broken by: OAK-3348 Cross gc sessions might introduce references to pre-compacted segments