[OAK-4219] ExternalLoginModuleTestBase doesn't remove synced User/Group accounts

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.19, 1.4.7, 1.5.2, 1.6.0
• Component/s: auth-external
• Epic Link: More tests for oak-auth-external
• Assignee: Angela Schreiber
• Reporter: Angela Schreiber
• Created: 18/Apr/16 12:47
• Updated: 10/Nov/16 09:41
• Resolved: 18/Apr/16 13:46

Description

Looking at the ExternalLoginModuleTestBase I got the impression that the cleanup of user/group accounts is effectively broken.

The current code looks as follows:

• in the before method the list of existing authorizables is collected
• in the after method the following code is executed:

  UserManager userManager = getUserManager(root);
              Iterator<Authorizable> iter = userManager.findAuthorizables("jcr:primaryType", null);
              while (iter.hasNext()) {
                  ids.remove(iter.next().getID());
              }
              for (String id : ids) {
                  Authorizable a = userManager.getAuthorizable(id);
                  if (a != null) {
                      a.remove();
                  }
              }
  

I might be totally mistaken but IMHO looks troublesome. Introducing an assertion after this verifying that the user with the external-test-id has been removed will actually fail... and I assume that this would have been the expected outcome.

So, I would have expected the after-method to remove all users/groups except those gather in the before-call, which would be considered built-in to the repository.