[OAK-4153] segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.29, 1.2.13, 1.4.1, 1.5.0
• Fix Version/s: 1.0.34, 1.2.19, 1.4.7, 1.5.1, 1.6.0
• Component/s: segmentmk
• Assignee: Stefan Egli
• Reporter: Stefan Egli
• Created: 29/Mar/16 11:56
• Updated: 26/Sep/19 11:41
• Resolved: 22/Aug/16 15:56

Description

SegmentNodeState.compareAgainstBaseState fails to call NodeStateDiff.childNodeDeleted when for the same parent the only child is deleted and at the same time multiple new, different children are added.

Reason is that the current code for 'afterChildName == MANY_CHILD_NODES' and 'beforeChildName == ONE_CHILD_NODE' does not handle all cases: it assumes that 'after' contains the 'before' child and doesn't handle the situation where the 'before' child has gone.