[OAK-4106] Reclaimed size reported by FileStore.cleanup is off

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: Segment Tar 0.0.10
• Component/s: segment-tar
• Labels: cleanup gc
• Epic Link: SegmentMK revision GC
• Assignee: Andrei Dulceanu
• Reporter: Michael Dürig
• Created: 08/Mar/16 19:49
• Updated: 04/Oct/19 17:50
• Resolved: 18/Aug/16 08:19

Description

The current implementation simply reports the difference between the repository size before cleanup to the size after cleanup. As cleanup runs concurrently to other commits, the size increase contributed by those is not accounted for. In the extreme case where cleanup cannot reclaim anything this can even result in negative values being reported.

We should either change the wording of the respective log message and speak of before and after sizes or adjust our calculation of reclaimed size (preferred).

Issue Links

• is related to: OAK-4657 Add metric for FileStore cleanup reclaimed size
• is related to: OAK-4667 Create IT to validate that reclaimed size after cleanup is always positive