[OAK-3330] FileStore lock contention with concurrent writers

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.9, 1.4
• Component/s: segmentmk
• Labels: compaction
• Epic Link: SegmentMK revision GC
• Assignee: Michael Dürig
• Reporter: Michael Dürig
• Created: 02/Sep/15 07:26
• Updated: 16/Feb/21 09:52
• Resolved: 13/Oct/15 14:21

Description

Concurrently writing to the file store can lead to a sever lock contention in FileStore#readSegment. That method searches the current TarWriter instance for the segment once it could not be found in any of the TarReader instances. This is the point where synchronizes on the FileStore instance, which leads to the contention.
The effect is only observable once the segment cache becomes full and reads actually need to go to the file store. Thus a possible improvement could be to pin segments from the current tar writer to the cache. Alternatively we could try to ease locking by employing read/write locks where possible.

Issue Links

• contains: OAK-4501 Avoid reading segment when reading strings and the string is in the cache