[OAK-3146] ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.21, 1.2.6, 1.3.5, 1.4
• Component/s: auth-external
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 27/Jul/15 14:34
• Updated: 02/Mar/16 12:08
• Resolved: 01/Sep/15 09:30

Description

ExternalLoginModule currently performs a lookup of SyncManager and ExternalIdentityProviderManager in initialize call which performs service lookup using ServiceTracker. Doing a service lookup in critical path would have adverse performance impact.

Instead of performing the lookup ExternalLoginModuleFactory should track the two manager instances and pass them to ExternalLoginModule. This would ensure that expensive operation like service lookup is not performed in critical path