[OAK-3081] SplitOperations may undo committed changes

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.0.10, 1.1.6, 1.2
• Fix Version/s: 1.0.17, 1.2.3, 1.3.3, 1.4
• Component/s: core, mongomk
• Assignee: Marcel Reutegger
• Reporter: Marcel Reutegger
• Created: 08/Jul/15 08:16
• Updated: 02/Mar/16 11:54
• Resolved: 08/Jul/15 12:40

Description

There is a race condition when SplitOperations identifies garbage on a document. The feature was introduced with OAK-2421.

The issue occurs if the following sequence of operations happens on a document:

• The document is updated with e.g. _deleted.rX-0-1 = false within Commit.applyToDocumentStore()
• Commit.createOrUpdateNode() perform the update and calls checkSplitCandidate(). The document becomes a split candidate, because it is over the threshold of 8kB
• At the same time a background update is running and starts to look at the split candidates.
• The background update looks at the document and calls SplitOperations.collectLocalChanges(). At this point _deleted.rX-0-1 = false is not committed and doc.isCommitted(rev) returns false
• The commit proceeds, updates the commit root and sets the new head revision
• The background update now calls SplitOperations.isGarbage(rX-0-1) and the method will return true!
• The background update then removes _deleted.rX-0-1 = false together with the _commitRoot entry