[OAK-2881] ConsistencyChecker#checkConsistency can't cope with inconsistent journal

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.3.8, 1.4
• Component/s: run
• Labels: resilience tooling
• Assignee: Michael Dürig
• Reporter: Michael Dürig
• Created: 18/May/15 10:01
• Updated: 02/Mar/16 14:31
• Resolved: 12/Oct/15 07:38

Description

When running the consistency checker against a repository with a corrupt journal, it fails with an ISA instead of trying to skip over invalid revision identifiers:

Exception in thread "main" java.lang.IllegalArgumentException: Bad record identifier: foobar
at org.apache.jackrabbit.oak.plugins.segment.RecordId.fromString(RecordId.java:57)
at org.apache.jackrabbit.oak.plugins.segment.file.FileStore.<init>(FileStore.java:227)
at org.apache.jackrabbit.oak.plugins.segment.file.FileStore.<init>(FileStore.java:178)
at org.apache.jackrabbit.oak.plugins.segment.file.FileStore.<init>(FileStore.java:156)
at org.apache.jackrabbit.oak.plugins.segment.file.FileStore.<init>(FileStore.java:166)
at org.apache.jackrabbit.oak.plugins.segment.file.FileStore$ReadOnlyStore.<init>(FileStore.java:805)
at org.apache.jackrabbit.oak.plugins.segment.file.tooling.ConsistencyChecker.<init>(ConsistencyChecker.java:108)
at org.apache.jackrabbit.oak.plugins.segment.file.tooling.ConsistencyChecker.checkConsistency(ConsistencyChecker.java:70)
at org.apache.jackrabbit.oak.run.Main.check(Main.java:701)
at org.apache.jackrabbit.oak.run.Main.main(Main.java:158)